search

speed47 / spectre-meltdown-checker

Reptar, Downfall, Zenbleed, ZombieLoad, RIDL, Fallout, Foreshadow, Spectre, Meltdown vulnerability/mitigation checker for Linux & BSD
3.85k stars 476 forks source link

Issue 429: analyse/lint and format script #435

Open thomasmerz opened 2 years ago

thomasmerz commented 2 years ago

This PR fixes #429 by these changes:

  👷 add a fancy GitHub action for 'shellcheck' and 'shfmt'
  👷 moved 'shellcheck' and 'check indentation' to new GitHub Action
  🚨 fix 'shellcheck' warnings
  🚨 fix 'shfmt' warnings

Contrary to my expectations I had to fix some warnings in spectre-meltdown-checker.sh which finalize in some minor changes. 🤷🏻‍♂️

Please have a look at my latest GitHub Action run in my forked repo:

image image image
thomasmerz commented 2 years ago

BTW: I use https://github.com/itspriddle/vim-shellcheck and https://github.com/z0mbix/vim-shfmt for local checking while writing/fixing code and https://github.com/nektos/act for a final local check running in a local GitHub Action in docker containers on my linux machine (which makes some trouble with the docker-in-docker steps on my linux machine 🤷🏻‍♂️ ).

thomasmerz commented 2 years ago

I also added some example GitHub Actions for a bad linting/shell syntax and a good (fixed) one.

thomasmerz commented 2 years ago

Hey @speed47 , can you please review this PR? Thank you.

thomasmerz commented 3 months ago

Hi @speed47 , before I start to resolve conflicts… are you fine with an GitHub Action based analyse/lint tool?