speed47 / spectre-meltdown-checker

Reptar, Downfall, Zenbleed, ZombieLoad, RIDL, Fallout, Foreshadow, Spectre, Meltdown vulnerability/mitigation checker for Linux & BSD
3.87k stars 476 forks source link

--update-fwdb fails with errors #443

Closed gene-git closed 1 year ago

gene-git commented 1 year ago

Starting today the --update-fwdb option fails:

Extracting MCEdb data... OK MCExtractor database revision 259
Integrating Intel firmwares data to db... Error: in prepare, no such column: intel
  NTO Intel (origin,cpuid,version,yyyymmdd)  ALUES ("intel","00000650","00000045
                                      error here ---^
speed47 commented 1 year ago

I can't reproduce the issue you have:

$ ./spectre-meltdown-checker.sh --update-fwdb
Spectre and Meltdown mitigation detection tool v0.45-2-gbea5cfc

Fetching MCE.db from the MCExtractor project... DONE
Fetching Intel firmwares... DONE
Extracting MCEdb data... OK MCExtractor database revision 260
Integrating Intel firmwares data to db... DONE (version 20230215)
Building local database... DONE (version 260+i20230215)

Do you still have the problem as of now? (I might have been a transient problem with the upstream fwdb)

gene-git commented 1 year ago

Yes - did fresh clone of repo - same problem.

Could it version of bash or sqlite3 maybe?

On Archlinux using these versions: bash 5.1.016-3 sqlite 3.41.0-1

gene-git commented 1 year ago

Only change from my prior is version is now 260 but error remains same.

speed47 commented 1 year ago

I can reproduce with Archlinux in a docker, checking...

EDIT: this change in sqlite3 3.41 is the culprit:

The double-quoted string misfeature is now disabled by default for CLI builds. Legacy use cases can reenable the misfeature at run-time using the ".dbconfig dqs_dml on" and ".dbconfig dqs_ddl on" commands.

A patch will be up in the next few minutes, thanks for catching this.

gene-git commented 1 year ago

Terrific thank you!

gene-git commented 1 year ago

I confirm its works fine - my builds will pick it up once it makes it to master.

thank you again. I left it to you to close this one if thats ok.