speedata / publisher

speedata Publisher - a professional database Publishing system
https://www.speedata.de/
GNU Affero General Public License v3.0
293 stars 36 forks source link

adds `border-radius` to `<Frame>` #492

Closed pr-apes closed 1 year ago

pr-apes commented 1 year ago

enables a single border-radius attribute for <Frame>

pr-apes commented 1 year ago

This comes from #459 (in a certain sense).

I think this:

<Frame framecolor="black" rulewidth="1pt" border-radius="7pt">

is better (or at least shorter) than this:

<Frame framecolor="black" rulewidth="1pt"
  border-top-left-radius="7pt"
  border-top-right-radius="7pt"
  border-bottom-left-radius="7pt"
  border-bottom-right-radius="7pt">

If you agree, other attributes might be simplified this way.

pgundlach commented 1 year ago

Thank you very much!

I have added these changes to commands.xml, so rake schema updates the four schema files and the documentation:

diff --git a/doc/commands-xml/commands.xml b/doc/commands-xml/commands.xml
index 8201e1c0..7a638cdc 100644
--- a/doc/commands-xml/commands.xml
+++ b/doc/commands-xml/commands.xml
@@ -3412,6 +3412,14 @@
         <para>Radius der Ecke unten links.</para>
       </description>
     </attribute>
+    <attribute en="border-radius" optional="yes" since="4.13.14">
+      <description xml:lang="en">
+        <para>Border rdius of the four corners.</para>
+      </description>
+      <description xml:lang="de">
+        <para>Radien aller vier Ecken.</para>
+      </description>
+    </attribute>
     <attribute en="framecolor" type="text" optional="yes">
       <description xml:lang="en">
         <para>The color of the frame around the object. Only makes sense in combination with the attribute 'frame'.</para>
pr-apes commented 1 year ago

Sorry, I forgot that the source was commands.xml.

BTW, there is a small typo (I hand edited to display radius [a is missing there]).

diff --git a/doc/commands-xml/commands.xml b/doc/commands-xml/commands.xml
index 8201e1c0..7a638cdc 100644
--- a/doc/commands-xml/commands.xml
+++ b/doc/commands-xml/commands.xml
@@ -3412,6 +3412,14 @@
       </description>
     </attribute>
    <attribute en="border-radius" optional="yes" since="4.13.14">
      <description xml:lang="en">
-        <para>Border rdius of the four corners.</para>
+        <para>Border radius of the four corners.</para>
      </description>
      <description xml:lang="de">
        <para>Radien aller vier Ecken.</para>
pr-apes commented 1 year ago

Sorry, the new commits weren't intended until this commit was solved.

But it seems that GitHub adds new commits to an open PR when the forked version has new pushed commits in the same branch where the original commits from the PR come from.

BTW, <Image margin=""> depends on #491 being fixed (sorry for not providing a patch, but I don't know what is wrong here).

pgundlach commented 1 year ago

Added with 7ec5e7ae1b1b6c4858039463fb09eefa3bd1e1e2

Thank you very much!