Windows installer truncates PATH?

speedata / publisher

speedata Publisher - a professional database Publishing system

https://www.speedata.de/

GNU Affero General Public License v3.0

296 stars 36 forks source link

Windows installer truncates PATH? #582

Open activivan opened 4 months ago

activivan commented 4 months ago

Windows installer (https://download.speedata.de/dl/speedata-publisher-windows-amd64-4.18.0-installer.exe) does not just add speedata to the user environment path variable, it overwrites it and deletes existing entries!

Edit (PG): This might be due to an overlong PATH variable which gets truncated during installation. Check!

pgundlach commented 4 months ago

Hello activian,

thank you very much for your bug report! I am afraid I cannot reproduce the problem. I have set a user PATH in the settings menu to "C:\Users\Patrick\Desktop\pg"

After installing the speedata Publisher with the file you link to, another Path entry has been added:

Is this not what you see?

Can you post a more detailed description of the problem? I am not a windows user, so I am very thankful for any help here.

activivan commented 4 months ago

Hey, I tried to recreate my problem, but this time it worked fine. If I recall, my original PATH variable was pretty long/full. After doing some research, I found out that NSIS (installer) can have difficulties with too long PATH variables (https://nsis.sourceforge.io/Path_Manipulation#Warning), though I don't know if this applies to the speedata Publisher. After installing speedata, I noticed that my PATH variable has been replaced, so I concluded that it was speedatas fault - of course I don't know for sure and maybe I'm wrong. Beste Grüße!

pgundlach commented 4 months ago

I think this is still an issue (truncating PATH variable), I will try to find a way to warn the user if this happens. Still thank you very much for brining this up!