search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
912 stars 71 forks source link

version: the build tag is incorrectly added to the RocksDB version string #231

Closed isaac-io closed 1 year ago

isaac-io commented 1 year ago

The changes in #156 were accidentally applied to the GetRocksVersionAsString() function instead of GetSpeedbVersionAsString(). This replaced ROCKSDB_PATCH with SPEEDB_PATCH (causing 7.2.2 to become 7.2.0), as well as added the tag in the wrong place (Speedb version: 2.1.0 (7.2.0-*-(main+4)-(#isaac/snapshot+1)) instead of Speedb version: 2.1.0-*-(main+4)-(#isaac/snapshot+1) (7.2.2)).

To Reproduce

  1. Build db_bench on any branch containing #156
  2. Run it and see the log file

Expected behavior

The RocksDB version patch isn't replaced, and the tag is applied to the Speedb version rather than the RocksDB one.

Additional context

N/A

isaac-io commented 1 year ago

@erez-speedb does this means that you'll need to make changes to the way the tag is extracted and shown in the admin site?