speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
898 stars 67 forks source link

Enable-Speedb-Feature: Use Scoped Pinning Policy instead of Default Policy #715

Closed udi-speedb closed 11 months ago

udi-speedb commented 11 months ago

@erez-speedb - Please run performance tests on the branch. Thanks

erez-speedb commented 11 months ago

@udi-speedb Perf tests passed https://admin.speedb.io/performance?items=txqdpiE3PH0YK0hdSGUR&items=xX2mdPxfNDEWa6QZzcqw&items=Yg8Bh0XhFWbIXsEcrjZi&colors=%23F06292&colors=%23BA68C8&colors=%239575CD

hilikspdb commented 11 months ago

@udi-speedb the pinning policy must be shared object between all the CF (and not recreated per CF) .. sorry that i have missed it

udi-speedb commented 11 months ago

@udi-speedb the pinning policy must be shared object between all the CF (and not recreated per CF) .. sorry that i have missed it

@hilikspdb - Indeed you are correct. I have also missed that.