speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
898 stars 67 forks source link

Use OptionsLogFormatter for Options::Dump #719

Open mrambacher opened 11 months ago

mrambacher commented 11 months ago

This PR replaces the code in the Options::Dump method with code using the Options infrastructure. A new "SerializePrintableOptions" method was added to the Configurable class which allows the values not serializable by the options to be included in the output. A ConfigOptions::Depth::KPrintable was added to tell the classes to invoked this method as part of the serialization process.

The Options::Dump methods now use the this infrastructure to generate their output. The code in the GetPrintableOptions methods of various was either deleted (because the values were serialized as Options) or moved into the SerializePrintableOptions method.

Guyme commented 10 months ago

@ofriedma after #651

ofriedma commented 10 months ago

@mrambacher can you please solve conflicts so I can review it?

mrambacher commented 9 months ago

This PR fixes #692

ofriedma commented 9 months ago

lgtm

ofriedma commented 9 months ago

I manually tested the ARM compile, it worked fine

CLAassistant commented 7 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 9 committers have signed the CLA.

:white_check_mark: Yuval-Ariel
:white_check_mark: ofriedma
:white_check_mark: udi-speedb
:white_check_mark: maxb-io
:x: mrambacher
:x: git-hulk
:x: GitHub Runner Bot
:x: zaidoon1
:x: ayulas


GitHub Runner Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.