search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
898 stars 67 forks source link

support enable speedb feature in CI #723

Closed ayulas closed 10 months ago

ayulas commented 11 months ago

support enable speedb feature in CI

Guyme commented 10 months ago

fixes : #726

Guyme commented 10 months ago

@Guyme will talk to @RoyBenMoshe and see where we take it from there

ayulas commented 10 months ago

@Guyme i talked with @RoyBenMoshe on Friday What he explained is that the design wasn’t supposed to support recover shared option To be able support db stress we need some adjustments to it Any way decide what you want to do

hilikspdb commented 10 months ago

The idea is that the user should call enable_sp.. before any open of the database (new or existing) . all the options that are set are mutable options and the user may change the parameters between runs and use different setting. Rocksdb lacks a config file that is shared between databases and while is see the value i do not think we should tie this project to it.

Guyme commented 10 months ago

to my understanding - to close this correctly we need to make sure that dbstress calls on enable_speedb in recovery

Guyme commented 10 months ago

@ayulas - #742 is now merged. Please fix the CI to use enable speedb in recovery as well

ayulas commented 10 months ago

Ok

ayulas commented 10 months ago

@ofriedma pls approve