search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
912 stars 71 forks source link

Expose Options::periodic_compaction_seconds via C API #741

Closed zaidoon1 closed 11 months ago

zaidoon1 commented 12 months ago

Created this pr in rocksdb repo: https://github.com/facebook/rocksdb/pull/12019 but it's unclear if/when the pr will be accepted. I'm working on switching to speedb so decided to make the change directly here.

udi-speedb commented 11 months ago

@zaidoon1 - I have just updated our CONTRIBUTING.md guide. When changing existing rocksdb files, we are adding our license text at the top, before the existing Facebook / LevelDB license text(s). Please add the license text to db/c_test.c file. Thanks

zaidoon1 commented 11 months ago

@zaidoon1 - I have just updated our CONTRIBUTING.md guide. When changing existing rocksdb files, we are adding our license text at the top, before the existing Facebook / LevelDB license text(s). Please add the license text to db/c_test.c file. Thanks

done

udi-speedb commented 11 months ago

@zaidoon1 - I have just updated our CONTRIBUTING.md guide. When changing existing rocksdb files, we are adding our license text at the top, before the existing Facebook / LevelDB license text(s). Please add the license text to db/c_test.c file. Thanks

done

Thanks. However, next time please don't force push. Just add a new commit. At the time of the merge, we are squashing all of the commits and make sure the commit message is correct.

udi-speedb commented 11 months ago

Hi, I am sorry but I have missed the required update to our HISTORY.md file. Please add a short description of your change under the "Enhancements" section of the Unreleased changes at the top. Thanks

zaidoon1 commented 11 months ago

Hi, I am sorry but I have missed the required update to our HISTORY.md file. Please add a short description of your change under the "Enhancements" section of the Unreleased changes at the top. Thanks

done