search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
898 stars 67 forks source link

db_bench: Sync applicable db_bench's properties with enable speedb features #743

Closed udi-speedb closed 8 months ago

udi-speedb commented 10 months ago

When activating enable speedb features in db_bench, we are creating and overriding Options' properties. db_bench has its own. For example, db_bench has its own cache handling that seems not to be fully synchronised with the SharedOptions's own cache entity:

  1. no_block_cache is set according to the dbbench's cache member.
  2. db_bench creates a SimCache as its cache if simcache_size >= 0.

We should review all the overrides that enables speedb features does and make sure they are fully synchronized with db_bench.

ofriedma commented 10 months ago

https://github.com/speedb-io/speedb/pull/765

ofriedma commented 9 months ago

@erez-speedb moved to performance in order to check if it doesn't fail for the performance tests, it doesn't affect the performance of the tool or the db itself.

erez-speedb commented 9 months ago

Passed perf test on hash 06fcbd35