search

speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
882 stars 65 forks source link

Export GetFlushReasonString/GetCompactionReasonString in listener.h #785

Closed git-hulk closed 7 months ago

git-hulk commented 8 months ago

The GetFlushReasonString/GetCompactionReasonString are exported in rocksdb(PR #11778) and Apache Kvrocks would like to use them to avoid copying those reason strings: https://github.com/apache/kvrocks/pull/1962

ofriedma commented 8 months ago

@git-hulk Thank you for contributing! Can you please rebase?

Thank you

git-hulk commented 8 months ago

@ofriedma Done

git-hulk commented 8 months ago

@ofriedma Should I worry about this CI failure?

ofriedma commented 8 months ago

@ofriedma Should I worry about this CI failure? @git-hulk no, it is related to another issue, and your commit will be added to our next version as well, thanks

git-hulk commented 8 months ago

@ofriedma Should I worry about this CI failure? @git-hulk no, it is related to another issue, and your commit will be added to our next version as well, thanks

Thank you!

ofriedma commented 7 months ago

@git-hulk could you please resolve the conflicts? thanks

git-hulk commented 7 months ago

@ofriedma done