Due to a last minute change before merging #30, the logger argument to CreateMemTableRep() is now unused. In some configurations where unused variables are treated as errors, this breaks the compilation.
This currently breaks the QA unit test runs.
To Reproduce
Compile main with -Werror and -Wunused-parameter. It fails with:
plugin/speedb/memtable/hash_spd_rep.cc: In member function 'virtual rocksdb::MemTableRep* rocksdb::HashSpdRepFactory::CreateMemTableRep(const rocksdb::MemTableRep::KeyComparator&, rocksdb::Allocator*, const rocksdb::SliceTransform*, rocksdb::Logger*)':
plugin/speedb/memtable/hash_spd_rep.cc:984:50: error: unused parameter 'logger' [-Werror=unused-parameter]
const SliceTransform* /*transform*/, Logger* logger) {
Expected behavior
Compilation succeeds.
System (please complete the following information)
Due to a last minute change before merging #30, the
logger
argument toCreateMemTableRep()
is now unused. In some configurations where unused variables are treated as errors, this breaks the compilation.This currently breaks the QA unit test runs.
To Reproduce
Compile
main
with-Werror
and-Wunused-parameter
. It fails with:Expected behavior
Compilation succeeds.
System (please complete the following information)
Additional context
N/A