speedb-io / speedb

A RocksDB compliant high performance scalable embedded key-value store
https://www.speedb.io/
Apache License 2.0
912 stars 71 forks source link

spdb_memtable: build fails due to an unused argumet #91

Closed isaac-io closed 2 years ago

isaac-io commented 2 years ago

Due to a last minute change before merging #30, the logger argument to CreateMemTableRep() is now unused. In some configurations where unused variables are treated as errors, this breaks the compilation.

This currently breaks the QA unit test runs.

To Reproduce

Compile main with -Werror and -Wunused-parameter. It fails with:

plugin/speedb/memtable/hash_spd_rep.cc: In member function 'virtual rocksdb::MemTableRep* rocksdb::HashSpdRepFactory::CreateMemTableRep(const rocksdb::MemTableRep::KeyComparator&, rocksdb::Allocator*, const rocksdb::SliceTransform*, rocksdb::Logger*)':
plugin/speedb/memtable/hash_spd_rep.cc:984:50: error: unused parameter 'logger' [-Werror=unused-parameter]
     const SliceTransform* /*transform*/, Logger* logger) {

Expected behavior

Compilation succeeds.

System (please complete the following information)

Additional context

N/A

isaac-io commented 2 years ago

Reported by @assaf-speedb