search

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.
MIT License
45 stars 34 forks source link

Custom Data for Teams #120

Open Floha258 opened 2 years ago

Floha258 commented 2 years ago

The name basically says it already, currently customData is only available for players of a team and a run itself, however not for a team in itself. Depending on how many players there are per team it might not be the best decision to give every player the custom Data that a team is only needed once per team.

zoton2 commented 2 years ago

I can add this very easily, just not sure if it will be able to be imported from anywhere. If you need that, are there any ideas on how you'd do that?

Floha258 commented 2 years ago

I would probably go about it similar as for single players, just make a customData field, which is an array of potential customData.

not sure if it will be able to be imported from anywhere

What would be the issue with that, if you would code it similar to the runner customData?

zoton2 commented 2 years ago

Well right now the player custom data doesn't get imported automatically from any schedule or external source so, uh, I guess there's no "issue" because it doesn't have it yet. Just adding the structure is fine.

Floha258 commented 2 years ago

My usecase (albeit a bit special) is a direct import in speedcontrol format already, so I have all the data at hand already. As said my usecase is rather special, but since player customData exists already, I feel like team customData should exist as well.