search

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.
MIT License
44 stars 34 forks source link

Message twitchStartCommercial does not return promise/callback #132

Open nicnacnic opened 2 years ago

nicnacnic commented 2 years ago

In the docs, twitchStartCommercial should be able to return a callback/promise, but instead it doesn't do that. It returns undefined instead and throws an error if you try to use a .then() .catch() block or the callback function.

zoton2 commented 2 years ago

I think I fixed that in this commit? It's just not been in any stable version yet as I hadn't released one. Should do that soon. Not sure if this fixes all of the problem though.

zoton2 commented 1 year ago

If that commit did fix this, then I've just released it as part of v2.5.0. Will close this if I hear nothing else.