search

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.
MIT License
44 stars 34 forks source link

Oengus schedule import does not import pronouns #145

Closed duncte123 closed 1 year ago

duncte123 commented 1 year ago

How to reproduce

  1. NodeCG version 1.9.0
  2. Import schedule from oengus (eg bsgo8)
  3. Have speedrun.com lookup disabled
  4. Import schedule

Expected behaviour

Speedcontrol imports the pronouns from the users on oengus.

Actual behaviour

Pronouns are blank

I've not been able to investigate why this is happening, the API returns them in the expected way according to the code.

duncte123 commented 1 year ago

Debug logs for importing from oengus, pronouns are already missing there

2023-03-25 12:52:58 - debug: [nodecg-speedcontrol] [Events] sendMessage triggered for "modifyRun": {"runData":{"teams":[{"id":"3
d32ebaf-4449-44ad-ab1c-18da8f78cc5a","players":[{"name":"Paulister","id":"632cbf01-8d31-4044-a6b9-2826b5d1bbe9","teamID":"3d32eb
af-4449-44ad-ab1c-18da8f78cc5a","social":{"twitch":"paulister"},"country":"gr","customData":{}}]}],"customData":{"layout":"16x9-
1p","intermission":"adwait180, bouncy,ad180,SpongebobGuessTheTimeDie"},"id":"161caab2-8c1d-491c-9366-fedfca354fbd","externalID":
"25609","game":"LOVE 3","system":"PC","category":"LOVE 3 (100%)","estimate":"00:23:00","estimateS":1380,"setupTime":"00:17:00","
setupTimeS":1020,"scheduled":"2023-03-25T10:26:00.000Z","scheduledS":1679739960}}
duncte123 commented 1 year ago

After long searching we found that it was broken in esa-layouts when the server was activated (bsg uses a custom server) https://github.com/BSGmarathon/esa-layouts/commit/e2c70ac9b7b26d6c733ac49f2248d295f524bef1