search

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.
MIT License
44 stars 34 forks source link

Use new oengus display names and support the youtube connection #149

Closed duncte123 closed 4 months ago

duncte123 commented 7 months ago

The Japanese username has been deprecated by the display name property.

Some people don't stream on twitch and use YouTube instead, Oengus supports a YouTube connection because of this. Speedcontrol should accept this connection as a separate input.

zoton2 commented 4 months ago

All seems good, only thing I did was to re-add the useJapanese setting to the configuration file schema, with a comment/description marking it as deprecated and needing to remove it in the next major version. My main reason for doing so was so people don't have NodeCG refusing to start up because of an unknown setting that could still be present.

duncte123 commented 4 months ago

All seems good, only thing I did was to re-add the useJapanese setting to the configuration file schema, with a comment/description marking it as deprecated and needing to remove it in the next major version. My main reason for doing so was so people don't have NodeCG refusing to start up because of an unknown setting that could still be present.

Good call on that one, it slipped my mind that this would happen as I removed the property on autopilot during development myself