search

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.
MIT License
45 stars 34 forks source link

openDialog is not a function #150

Open tryptech opened 4 months ago

tryptech commented 4 months ago

Recently did a new install of nodecg and nodecg-speedcontrol.

Whenever I try to click a button that opens a dialog window (add/remove run, import from oengus, etc.), I get this error in the browser console: image

zoton2 commented 4 months ago

This is an issue with NodeCG v2.2.2 with the iframe lazy loading change (https://github.com/nodecg/nodecg/pull/729). I reported it in their Discord last night, will make an issue soon. The workaround is to use NodeCG v2.2.1 for now.

zoton2 commented 4 months ago

So it turns out only my custom function is an issue, you can programmatically open the dialogs just fine, but I need my custom functions, so for now I've implemented a check before they are opened where if it's not loaded, it quickly opens and closes the dialog. This is available on master/build if you want to try it out. Will hopefully release a new version fully at the start of August (this will be tested at an event).