Speedcontrol crashes on FFZ intergration HTTP error

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.

MIT License

45 stars 34 forks source link

Speedcontrol crashes on FFZ intergration HTTP error #4

Closed j4sp3rr closed 7 years ago

j4sp3rr commented 8 years ago

When the FFZ intergration meets some http error (503 in my case) from the websocket server all of speedcontrol will immidiately quit out and crash, can these errors somehow be caught and disable just FFZ intergration with a warning. possibly even try all 3 websocket addresses before giving up? "catbag.frankerfacez.com", "andknuckles.frankerfacez.com", "tuturu.frankerfacez.com" these addresses were taken from chatty code which cycles between all 3 of them.

zoton2 commented 7 years ago

I think this issue shouldn't have happened/been fixed when you posted it, but I will close it because in testing it seems to not crash right now, and if you get an error, such as a 503, it will then attempt to reconnect (randomly to 1 of the 3 servers) after 10 seconds. Right now it won't stop ever even if it can't get a connection, but I've never seen all 3 servers refuse connections at once myself.