search

speedcontrol / nodecg-speedcontrol

NodeCG bundle to help facilitate the running of speedrunning marathons, including overlays.
MIT License
45 stars 34 forks source link

Improve TypeScript in Vue.js code #58

Closed zoton2 closed 4 years ago

zoton2 commented 5 years ago

For some reason right now in Visual Studio Code I am not being alerted to Typescript issues in *.vue like I am in pure *.ts files. I think I could move all of the code to *.ts files but not sure how well that works. I have fixed some things that ESLint brings up but it still needs improving.

zoton2 commented 5 years ago

Seems like a recent Vetur update broke TypeScript checking except for the first file opened (vuejs/vetur#1449) so this was one of my issues where I wouldn't notice it. Also, Parcel doesn't tell you about TypeScript issues when transpiling either, so trying to move over to Webpack although it's a little more tricky.

zoton2 commented 5 years ago

I would also like to move over to using vue-class-component/vue-property-decorator/vuex-class, but not for v2.0.0 final release.

zoton2 commented 4 years ago

Have now finally moved over the using decorators in dev branch, enabled type checking and fixed any issues I found.