search

speedruncomorg / api

REST API Documentation for speedrun.com
346 stars 36 forks source link

Guests can have a `null` name, which is undocumented. #122

Open badBlackShark opened 3 years ago

badBlackShark commented 3 years ago

Fetching all runs done on a PC not only always fails (#121), but also produces three runs done by a guest with no name before it does so. None of these runs are accessible through the site (a blank page will be displayed). Here are three runs in question: On the site: https://www.speedrun.com/gtasa/run/z1oexrjm, https://www.speedrun.com/gtasa/run/y6r1gx0y, https://www.speedrun.com/gtasa/run/z18k5w9y

Through the API: https://www.speedrun.com/api/v1/runs/z1oexrjm, https://www.speedrun.com/api/v1/runs/y6r1gx0y, https://www.speedrun.com/api/v1/runs/z18k5w9y

I find this behavior fairly unusual and think it should at the very least be documented.

mitchell-merry commented 2 years ago

Not sure what was shown before, but it looks like now these just return an empty players array [], whether or not you embed players onto the resource. Which is probably fine behavior.