search

speedruncomorg / api

REST API Documentation for speedrun.com
346 stars 36 forks source link

Run verifiers referred to as `super-moderator` #129

Open exodustx0 opened 3 years ago

exodustx0 commented 3 years ago

For example, take this endpoint, representing the game Riven. If you embed moderators, you can see that ID zkzw2g9x refers to a user that's currently a verifier for the game. Call again without the embed query (because when embedding moderators, the users' role for the game aren't included), and you'll see this ID listed as referring to a super-moderator.

(EDIT - the above example is no longer useful, as that user is no longer a verifier on that leaderboard. See this comment for a live example.)

bigfoott commented 3 years ago

I hadn't noticed this until now but I'm seeing the same issue. On I Expect You To Die, there's one super mod and two verifiers, but the games endpoint shows three super mods.

Suprnova commented 3 years ago

Speedrun.com's backend has a single key for the status of moderators, called "super". A value of 1 means that the user is a super mod, and a value of 0 means that the user is a regular mod. When introducing verifiers to the website, they made the weird decision of making a value of -1 mean that a user is a verifier. If I had to guess, especially since the API hasn't been meaningfully updated in a while, the API does not recognise this "super: -1" value, and just defaults to a value of 1. A simple fix of the API to recognise this new value would likely solve this issue.

mitchell-merry commented 2 years ago

Really gross that this is still a thing.

xJade00 commented 1 year ago

Still seeing this, are there any members on the API team at speedrun.com or is it a backburner project?

bigfoott commented 1 year ago

are there any members on the API team at speedrun.com or is it a backburner project?

From my understanding there are, but they don't use this repo.

YummyBacon5 commented 1 year ago

or is it a backburner project

Occasionally, the API gets updates, but not the docs, Camcorder has said that this is because they "only have so much engineering bandwidth". Also, SRC are working on an API v2, which won't be out for a long time

mitchell-merry commented 1 year ago

they should just hire me and I would fix it 4Head