search

speedskater / babel-plugin-rewire

A babel plugin adding the ability to rewire module dependencies. This enables to mock modules for testing purposes.
843 stars 90 forks source link

Avoid rewiring LHS of ForInStatements #185

Closed mikesherov closed 7 years ago

mikesherov commented 7 years ago

Thanks again for the great plugin! Please consider accepting this PR and releasing a new version at your earliest convenience. Thanks again!

mikesherov commented 7 years ago

Actually, I need to add forOfStatements as well.

mikesherov commented 7 years ago

ForOfStatements will require a lot more work actually, so I'd love to land this fix for ForIn and later I can address ForOfStatement.

speedskater commented 7 years ago

@mikesherov thank your for providing the PR and the transformation test. I will merge your additions today. I will first write a short sample test.

speedskater commented 7 years ago

@mikesherov Merged your branch onto version 1.1.0 branch.

speedskater commented 7 years ago

@mikesherov Merged onto 1.1.0 branch will be part of the next build (today).