speedskater / babel-plugin-rewire

A babel plugin adding the ability to rewire module dependencies. This enables to mock modules for testing purposes.
843 stars 90 forks source link

Fixes undefined __$$GLOBAL_REWIRE_REGISTRY__ error. #195

Open destenson opened 7 years ago

destenson commented 7 years ago

Fixes undefined variable probably due to copy/paste oversight that causes problems downstream with redbox-react.

This fix should also go into the 2.x branch.

See https://github.com/naviapps/nw-react-boilerplate/issues/4 for the bug that this fixes.

speedskater commented 6 years ago

@destenson Thank your for your PR and sorry for my very late reply. I finally managed to tmerged it into the 1.2.0 branch and puglished 1.2.0-rc.1 on npm as a prerelease. Could you please test this release in your code bases. If I won't get any negativ feedback till next monday I will convert it to the final 1.2.0 and will then merge it onto master.

speedskater commented 6 years ago

I also added you as a contributor to the README. I hope this is okay with you?