search

speedskater / babel-plugin-rewire

A babel plugin adding the ability to rewire module dependencies. This enables to mock modules for testing purposes.
843 stars 90 forks source link

return revert function from __set__ with object #198

Closed twhitbeck closed 6 years ago

twhitbeck commented 6 years ago

resolves #197

twhitbeck commented 6 years ago

@nene I think you originally contributed the __set__ with object functionality. Is there a reason you left out the revert? Or did that come later?

nene commented 6 years ago

I guess I did not have a need for reverting.

speedskater commented 6 years ago

@twhitbeck Thank your for your PR and sorry for my very late reply. I finally managed to merged it into the 1.2.0 branch and puglished 1.2.0-rc.1 on npm as a prerelease. I also added you as a contributor to the README. I hope this is okay with you? Could you please test this release in your code bases. If I won't get any negativ feedback till next monday I will convert it to the final 1.2.0 and will then merge it onto master.

twhitbeck commented 6 years ago

@speedskater that's great, thanks! What's up with the failing tests? do you need me to rebase this PR?