search

speedy32129 / time_logger

Redmine Time logger plugin. More than likely there is only going to be one more public release. New version has new time logging with the option of multiple loggers running at the same time, fixes for excessive loggng, and a whole new look.
Other
59 stars 43 forks source link

Transitions not displaying after creation. #2

Closed speedy32129 closed 9 years ago

speedy32129 commented 10 years ago

Currently in the configuration of time_logger when you add a transition it's not saving.

Peneheals commented 10 years ago

Agreed. What should be the problem? How can I manually add a time entry to the db temporarly?

speedy32129 commented 10 years ago

Not sure I completely understand what you are asking. This has nothing to do with adding time. The time_logger is logging time and saving time.

This particular issue has to do with status transitions. So if an issue has a status of "new" and you setup a transition from "new" to "in progress" when you start an issue with a "new" status" it will change to "in progress". You can still do that manually in the issue.

Peneheals commented 10 years ago

Yes, I know that, sorry for the inconvenience.

tvdeyen commented 9 years ago

Sorry, I didn't saw this issue before opening #7

I guess the problem is:

  1. The :url => key in the link_to helper on https://github.com/speedy32129/time_logger/blob/master/app/views/time_loggers/_status_transition_list.html.erb#L69. It just has to be the hash, without the :url => key.
  2. We need to update the old Prototype based javascript option :with and :complete. :complete can easily be replaced with data-replace, and the :with option need to be replaced with a custom data-with option, that injects the params into ajax calls for links with data-with, like you already did with data-replace in https://github.com/speedy32129/time_logger/blob/master/app/views/time_loggers/_update_menu.html.erb#L39-L47

Maybe I'll find some time tomorrow to fix this.

Thanks again for your work on this plugin.

tvdeyen commented 9 years ago

10 Fixes the issues