poxtihc
commented
7 years ago Hi, i have de same problem..¿any idea?
Open ppoektos opened 7 years ago
poxtihc
commented
7 years ago Hi, i have de same problem..¿any idea?
ppoektos
commented
7 years ago I made config.log_level = :warn in additional_environment.rb and restarted redmine.
poxtihc
commented
7 years ago Same result..
ActionController::RoutingError (No route matches [GET] "/time_loggers/render_menu"):
actionpack (4.2.6) lib/action_dispatch/middleware/debug_exceptions.rb:21:in call' actionpack (4.2.6) lib/action_dispatch/middleware/show_exceptions.rb:30:incall'
railties (4.2.6) lib/rails/rack/logger.rb:38:in call_app' railties (4.2.6) lib/rails/rack/logger.rb:20:inblock in call'
activesupport (4.2.6) lib/active_support/tagged_logging.rb:68:in block in tagged' activesupport (4.2.6) lib/active_support/tagged_logging.rb:26:intagged'
activesupport (4.2.6) lib/active_support/tagged_logging.rb:68:in tagged' railties (4.2.6) lib/rails/rack/logger.rb:20:incall'
actionpack (4.2.6) lib/action_dispatch/middleware/request_id.rb:21:in call' rack (1.6.4) lib/rack/methodoverride.rb:22:incall'
rack (1.6.4) lib/rack/runtime.rb:18:in call' activesupport (4.2.6) lib/active_support/cache/strategy/local_cache_middleware.rb:28:incall'
actionpack (4.2.6) lib/action_dispatch/middleware/static.rb:120:in call' rack (1.6.4) lib/rack/sendfile.rb:113:incall'
railties (4.2.6) lib/rails/engine.rb:518:in call' railties (4.2.6) lib/rails/application.rb:165:incall'
railties (4.2.6) lib/rails/railtie.rb:194:in public_send' railties (4.2.6) lib/rails/railtie.rb:194:inmethod_missing'
/usr/lib/ruby/vendor_ruby/phusion_passenger/rack/thread_handler_extension.rb:97:in process_request' /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:152:inaccept_and_process_next_request'
/usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:113:in main_loop' /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler.rb:416:inblock (3 levels) in start_threads'
/usr/lib/ruby/vendor_ruby/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'
speedy32129
commented
7 years ago I've tried to reproduce this an I can't but here's a couple of things you can do.
Did you remove the directory? ../plugins/time_logger If the directory is still there remove it. Restart web server. Check to see if that fixed the issue.
It that doesn't fix it
Also run query against the database select * from schema_migrations where version like "%time_logger%" limit 0,25
If it exists delete it
delete from schema_migrations where version like "%time_logger%"
Restart Web server and check again.
danaivehr
commented
7 years ago Hi! Having such issue too. Furthermore, after re-installing the plugin log is flooding with succesful "render_menu" gets every moment, wich is not good too.
After some digging it appears that apache access_log is flooding with "GET /time_loggers/render_menu" from several IP's constantly. Seems like a problem on a client side.
Can't say if it's bacause of open tab in browser on client side or some other issue.
speedy32129
commented
7 years ago I finally have been able to reproduce the issue. I'll let you all know when I have an update.
muriloht
commented
7 years ago Hi, I'm also getting this log messages... and when it happens the "play, pause and stop" buttons don't appear... if I can help with something, please let me know
danaivehr
commented
7 years ago I just performed some investigations and think that the main issue is using setInterval() for updateTimeLoggerMenu which gets data from server. It causes constant GET requests even if user doesn't see timer (in a foreground browser tab left overnight, just for example). If we have, say, 20 users, they have 5 tabs open with issues, its like a 100 useless additional requests per minute.
I found some examples to get "Tab is visible" property (see "Using the PageVisibility API" topic on html5rocks) and managed to apply them to logger. The main idia is to setIntervar when tab is visible and clear it otherwise. Code looks like this:
function getHiddenProp(){
var prefixes = ['webkit','moz','ms','o'];
// if 'hidden' is natively supported just return it
if ('hidden' in document) return 'hidden';
// otherwise loop over all the known prefixes until we find one
for (var i = 0; i < prefixes.length; i++){
if ((prefixes[i] + 'Hidden') in document).
return prefixes[i] + 'Hidden';
}
// otherwise it's not supported
return null;
}
function isHidden() {
var prop = getHiddenProp();
if (!prop) return false;
return document[prop];
}
// use the property name to generate the prefixed event name
var visProp = getHiddenProp();
if (visProp) {
var evtname = visProp.replace(/[H|h]idden/,'') + 'visibilitychange';
document.addEventListener(evtname, visChange);
}
var interval = null;
function visChange() {
if (isHidden())
clearInterval(interval);
else {
updateTimeLoggerMenu();
interval = setInterval(updateTimeLoggerMenu, 60000);
}
}Working well for me. It would be great if you'll review it and implement it in your plugin.
Please notice that HTML5 must be supported to get it working, and if not, timer won't refresh (in my case i just don't care, but you can add "else setInterval(updateTimeLoggerMenu, 60000);" to "if (visProp)" just for compatibility).
poxtihc
commented
7 years ago I've tried to reproduce this an I can't but here's a couple of things you can do.
Did you remove the directory? ../plugins/time_logger If the directory is still there remove it. Restart web server. Check to see if that fixed the issue.
It that doesn't fix it Also run query against the database select * from schema_migrations where version like "%time_logger%" limit 0,25
If it exists delete it delete from schema_migrations where version like "%time_logger%"
Restart Web server and check again.
No results removing ../plugins/time_logger and delete from schema_migrations where version like "%time_logger%"
ActionController::RoutingError (No route matches [GET] "/time_loggers/render_menu"):
actionpack (4.2.6) lib/action_dispatch/middleware/debug_exceptions.rb:21:in call' actionpack (4.2.6) lib/action_dispatch/middleware/show_exceptions.rb:30:incall'
railties (4.2.6) lib/rails/rack/logger.rb:38:in call_app' railties (4.2.6) lib/rails/rack/logger.rb:20:inblock in call'
activesupport (4.2.6) lib/active_support/tagged_logging.rb:68:in block in tagged' activesupport (4.2.6) lib/active_support/tagged_logging.rb:26:intagged'
activesupport (4.2.6) lib/active_support/tagged_logging.rb:68:in tagged' railties (4.2.6) lib/rails/rack/logger.rb:20:incall'
actionpack (4.2.6) lib/action_dispatch/middleware/request_id.rb:21:in call' rack (1.6.5) lib/rack/methodoverride.rb:22:incall'
rack (1.6.5) lib/rack/runtime.rb:18:in call' activesupport (4.2.6) lib/active_support/cache/strategy/local_cache_middleware.rb:28:incall'
actionpack (4.2.6) lib/action_dispatch/middleware/static.rb:120:in call' rack (1.6.5) lib/rack/sendfile.rb:113:incall'
railties (4.2.6) lib/rails/engine.rb:518:in call' railties (4.2.6) lib/rails/application.rb:165:incall'
railties (4.2.6) lib/rails/railtie.rb:194:in public_send' railties (4.2.6) lib/rails/railtie.rb:194:inmethod_missing'
/usr/lib/ruby/vendor_ruby/phusion_passenger/rack/thread_handler_extension.rb:97:in process_request' /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:152:inaccept_and_process_next_request'
/usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:113:in main_loop' /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler.rb:416:inblock (3 levels) in start_threads'
/usr/lib/ruby/vendor_ruby/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'
speedy32129
commented
5 years ago ok I've figured this out!! I'm now using a real ide so tracing this was pretty easy. The first issue is when uninstalling the plugin the public_assets do not get removed.
Make sure to delete the plugin directory ../plugins/time_logger You'll also have to remove ../public/plugin_assets/time_logger !!! This is a Rails bug and hasn't been fix for some time.
danaivehr I like your idea could you please share the file or clone my project so I can give you credit for helping fixing the issue.
danaivehr
commented
4 years ago @speedy32129 hello there after years! =)
Here is the app/views/time_loggers/_update_menu.html.erb file with that changes from https://github.com/speedy32129/time_logger/issues/43#issuecomment-285872703
<% if User.current.logged? and @project.present? and global_allowed_to?(User.current, :view_time_logger) %>
<script type="text/javascript">
$(function() {
function updateStatus() {
$.ajax({
url:"<%=url_for :controller => '/time_loggers',:action => 'render_toolbar' %>",
data:({<%= (@project.nil? ? nil : "project_id:#{@project.id},") %><%= (@issue.nil? ? nil : "issue_id:#{@issue.id}") %> }),
cache:false,
success: function(data){
$('#time-logger-toolbar').replaceWith(data);
},
error: function(error) {
var message = '<%= escape_javascript(l('time_logger_connection_lost')) %>'
message += ' <a href="#" data-time-logger-refresh="true">Retry</a>'
$('#time-logger-toolbar .timer-task').html(message)
}
});
}
function getHiddenProp(){
var prefixes = ['webkit','moz','ms','o'];
// if 'hidden' is natively supported just return it
if ('hidden' in document) return 'hidden';
// otherwise loop over all the known prefixes until we find one
for (var i = 0; i < prefixes.length; i++){
if ((prefixes[i] + 'Hidden') in document)
return prefixes[i] + 'Hidden';
}
// otherwise it's not supported
return null;
}
function isHidden() {
var prop = getHiddenProp();
if (!prop) return false;
return document[prop];
}
// use the property name to generate the prefixed event name
var visProp = getHiddenProp();
if (visProp) {
var evtname = visProp.replace(/[H|h]idden/,'') + 'visibilitychange';
document.addEventListener(evtname, visChange);
}
var interval = null;
function visChange() {
if (isHidden())
clearInterval(interval);
else {
update();
interval = setInterval(update, 60000);
}
}
function update() {
updateStatus();
//updateIssues();
}
jQuery(document).ready(function($){
$('#main').prepend('<%= escape_javascript(render :partial => 'time_loggers/toolbar') %>');
//$(document).on('click', '[data-time-logger-refresh]', update)
//setInterval(update, 60000);
//updateIssues();
});
});
</script>
<% end %>
Since I installed plugin it constantly writes to log few records per one minutes even in the night when nobody works:
So I uninstalled plugin but somehow (maybe because of cookies) now there are massive flood with errors: