search

speedy32129 / time_logger

Redmine Time logger plugin. More than likely there is only going to be one more public release. New version has new time logging with the option of multiple loggers running at the same time, fixes for excessive loggng, and a whole new look.
Other
59 stars 43 forks source link

jQuery 1.11 compatibility #6

Closed 646b closed 9 years ago

646b commented 9 years ago

Timer in menu stopped working when I've upgraded redmine to version 2.6. The reason was the removal of live method in new jQuery (see http://api.jquery.com/live/). I've replaced live with on method.

speedy32129 commented 9 years ago

Is this just and upgrade for jquery 1.11 as it didn't seem to fix the issue. Status changes still aren't showing

646b commented 9 years ago

This commit only fixes JS error while working with timer in menu and not related to status transitions.

tvdeyen commented 9 years ago

@speedy32129 jQuery live is deprecated a long time in favour of on, so the merge is save.

tvdeyen commented 9 years ago

We should use the solution from #10 because that handles replaced DOM elements. This approach here only works after reloading the page. If an DOM element gets replaced, like the "add transition" button in the settings, the event won't work anymore.