search

speedy32129 / time_logger

Redmine Time logger plugin. More than likely there is only going to be one more public release. New version has new time logging with the option of multiple loggers running at the same time, fixes for excessive loggng, and a whole new look.
Other
58 stars 43 forks source link

Redmine 4.2 compatibility #68

Open fwolfst opened 2 years ago

fwolfst commented 2 years ago

Currently is not compatible with 4.2 (even with patch from #67). The error thrown is super weird:

App 10224 output: Completed 500 Internal Server Error in 226ms (ActiveRecord: 106.6ms)
App 10224 output:   
App 10224 output: ArgumentError (wrong number of arguments (given 2, expected 0..1)):
App 10224 output:   
App 10224 output: plugins/time_logger/app/models/time_logger.rb:15:in `initialize'
App 10224 output: plugins/time_logger/app/controllers/time_loggers_controller.rb:18:in `start'

If somebody solves that riddle, I am curious to read the solution.

fwolfst commented 2 years ago

Just for fun, here the code references: :confused: https://github.com/speedy32129/time_logger/blob/6ecf2f59b095b7a7d19cb2a94f1c308debd5fefb/app/controllers/time_loggers_controller.rb#L18 https://github.com/speedy32129/time_logger/blob/6ecf2f59b095b7a7d19cb2a94f1c308debd5fefb/app/models/time_logger.rb#L15

fwolfst commented 2 years ago

Okay, solved in https://github.com/speedy32129/time_logger/issues/65#issuecomment-757379838 .

Still, I dont really get it. I had also modified the code to define an empty initialize and pass no arguments in the controller.