search

speee / webapp-revieee

MIT License
39 stars 2 forks source link

adding guard clause to delete method in review_app_target.rb #42

Closed selmertsx closed 7 years ago

selmertsx commented 7 years ago

container and task_definition cannot create, if task is not exist when GitHub synchronized action occurs.

task is only created, when PRs were created. if error occurs when PR was created, task is not created.

/usr/local/review_apps/releases/20170418014012/app/models/review_app_target.rb:16:in `delete': undefined method `stop' for nil:NilClass (NoMethodError)
        from /usr/local/review_apps/releases/20170418014012/app/models/review_app_target.rb:22:in `update'
        from /usr/local/review_apps/releases/20170418014012/app/models/pull_request/actions/synchronized.rb:3:in `handle'
pataiji commented 7 years ago

LGTM :+1:

selmertsx commented 7 years ago

レビューありがとうございます！