spegelius / filaswitch

Filament switch post processor for 3D printing
GNU General Public License v3.0
39 stars 11 forks source link

bug #34

Closed wbarber69 closed 6 years ago

wbarber69 commented 6 years ago

the latest release gives me this error. C:\filaswitch5>filaswitch.bat Traceback (most recent call last): File "C:\filaswitch5\\src\filaswitch.py", line 300, in <module> main() File "C:\filaswitch5\\src\filaswitch.py", line 271, in main gui = GUI() File "C:\filaswitch5\\src\filaswitch.py", line 231, in __init__ self.log = Logger(os.path.join(root_dir, "logs")) File "C:\filaswitch5\src\logger.py", line 12, in __init__ self.filehandler = logging.FileHandler(os.path.join(logdir, "filaswitch.log")) File "C:\Users\Walter Barber\AppData\Local\Programs\Python\Python36-32\lib\logging\__init__.py", line 1030, in __init__ StreamHandler.__init__(self, self._open()) File "C:\Users\Walter Barber\AppData\Local\Programs\Python\Python36-32\lib\logging\__init__.py", line 1059, in _open return open(self.baseFilename, self.mode, encoding=self.encoding) FileNotFoundError: [Errno 2] No such file or directory: 'C:\\filaswitch5\\logs\\filaswitch.log'

wbarber69 commented 6 years ago

adding the folder and file manually fixed it. but it needs adressing

wbarber69 commented 6 years ago

also spaces in file names are no longer supported

cfelicio commented 6 years ago

same here, adding the logs folder manually fixed it.

wbarber69 commented 6 years ago

I have confirmed that there is an issue with spaces in file names. I have reverted to a previous version and it works just fine.

spegelius commented 6 years ago

Ok logs dir is easy to fix, but more details needed for white space problem: cannot open files that have white space or filaswitch cannot be in folder that has white space? Those both I tested if I recall correctly...

spegelius commented 6 years ago

Well, tried opening filaswitch extracte a dir that has white space and it starts fine. Sliced a while that's in a dir that has white space, works fine. Using the filaswitch.bat from cmdline seems to cause problems, however

spegelius commented 6 years ago

Ok, for me the problem as - character in the path, There's a fix attempt in master branch

wbarber69 commented 6 years ago

yes i do have a - in my gcode path but it was cutting my commands off at the spaces and calling anyting between the spaces another command switch even with quotations around the whole thing

wbarber69 commented 6 years ago

bug squashed

wbarber69 commented 6 years ago

Swapped out filaswitch.bat for the latest. And the issue seems to have gone away, and s3d post processing happens as normal. Now just to add in a way to upload it straight to octoprint and we got a finished product here.

Sent from my iPhone

On Jan 28, 2018, at 3:17 AM, Pekka Piippo notifications@github.com<mailto:notifications@github.com> wrote:

Ok, for me the problem as - character in the path, There's a fix attempt in master branch

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fspegelius%2Ffilaswitch%2Fissues%2F34%23issuecomment-361048923&data=02%7C01%7C%7C46a25869840640029fee08d5662ff2e0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636527278473004898&sdata=3p5%2FQjZCpOqHiOXcSKlGDxsTwTnEG4eOwv8n8g1VSZc%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB7M2pInDLAcgHM0jh0AC827gV9HZCm2ks5tPDsmgaJpZM4RvhIn&data=02%7C01%7C%7C46a25869840640029fee08d5662ff2e0%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636527278473004898&sdata=jgnI6awdTuzLyB%2BztHvy6z6shrpNx%2BDNA9I3LOiNWWQ%3D&reserved=0.