spegoraro / org-alert

System notifications of org agenda items
GNU General Public License v3.0
278 stars 26 forks source link

Configurable alert cutoff for each entry #30

Closed pataquets closed 1 year ago

pataquets commented 1 year ago

Having a single default cutoff for every entry does not work in some cases. Eg: 10m may be enough time for an online meeting, but it won't cut it if you have an in-person meeting at the other end of the city and you have to drive. AFAIK, there is not such a property to set the cutoff time different than the scheduled time.

ntBre commented 1 year ago

I totally agree, I think this is why I've left #20 open too. I've been meaning to look into this, but I'd be glad to accept a PR for it if you want to give it a try.

ntBre commented 1 year ago

I think I handled this in bddb342. I used the suggested property name from #20 (REMINDERN), but also added a variable org-alert-cutoff-prop so that you can set your own. Give it a try and let me know if you run into any issues!

pataquets commented 1 year ago

That's great, @ntBre. Thank you! The customizable property name it's a smart addition. Tip for those using akhramov/org-wild-notifier.el: the property name should be WILD_NOTIFIER_NOTIFY_BEFORE. Also, I'm afraid you forgot to cross out the last item in the readme's TODO section :grin:

ntBre commented 1 year ago

No problem, thanks for the suggestion! Ahh, good catch on the readme. I'll delete that TODO and add what you said about org-wild-notifier too. Thanks again!