Change `defvar` to `defcustom`?

spegoraro / org-alert

System notifications of org agenda items

GNU General Public License v3.0

277 stars 25 forks source link

Change `defvar` to `defcustom`? #38

Closed rennsax closed 3 months ago

rennsax commented 3 months ago

Hi, would you mind preferring defcustom than defvar for customizable variables, so the user can find them in the Customization UI?

ntBre commented 3 months ago

Sure, I didn't even think about that! That should just be a simple substitution for all of the variables right, or are there other implications I'm not considering?

rennsax commented 3 months ago

Hi, I create the PR #39. Reviews are welcome!

ntBre commented 3 months ago

Just merged #39, so closing this one. Thanks again!