search

spekframework / spek

A specification framework for Kotlin
Other
2.23k stars 179 forks source link

[2.x] Add support for IJ 2021.2 #977

Closed echeble closed 3 years ago

echeble commented 3 years ago

Upgrade plugin's supporting versions following the release of IDEA 2021.2

raniejade commented 3 years ago

thanks for this @eacheble!

echeble commented 3 years ago

seems it's failing to pull from the release... maybe I have a typo in the version 🤔

raniejade commented 3 years ago

You can take a look here: https://www.jetbrains.com/intellij-repository/releases/ if the version exists.

echeble commented 3 years ago

this time I actually tested that the kotlin version is reachable, so hopefully last commit will pass the pr build checks 🤞 If this one goes well then I'll mimic the changes on https://github.com/spekframework/spek/pull/978

echeble commented 3 years ago

@raniejade do you think we're ok with this one? Can you also launch the build checks on https://github.com/spekframework/spek/pull/978? I replicated the changes I made here and this time will pass

raniejade commented 3 years ago

This is good, thanks again @eacheble! I'll run the build for #978.

t0r0X commented 3 years ago

This ticket and #978 superceded by #979

echeble commented 3 years ago

This ticket and #978 superceded by #979

@t0r0X I don't think that's entirely accurate. This aims to a branch (2.x) which is different than 978 & 979 branch (both 2.0.x)

t0r0X commented 3 years ago

This ticket and #978 superceded by #979

@t0r0X I don't think that's entirely accurate. This aims to a branch (2.x) which is different than 978 & 979 branch (both 2.0.x)

@eacheble You're right, I've overlooked that branch.