search

spekt / junit.testlogger

JUnit test logger for vstest platform (<= v3.x)
MIT License
77 stars 15 forks source link

Add CircleCI to this repo #3

Closed codito closed 4 months ago

codito commented 5 years ago

Would be a nice way to ~dogfood~ validate the junit logger on itself! :)

Siphonophora commented 5 years ago

Ha, sounds good. I'm wiring up the pre-release package to some repositories at work and will see if I have any issues. I haven't used circle Ci, but can give that a shot when I have some time.

Siphonophora commented 5 years ago

@codito Since CircleCI is running in a linux container, It can't build the Net Framework project as part of building the acceptance testing project. This pipeline is a mess from trying to figure this out, but the issue is clear: https://circleci.com/gh/Siphonophora/junit.testlogger/12 I'd rather not change anything else about the acceptance testing proj just for this.

I have tested the pre release package with a handful of different projects and haven't had any issues with stability. I found the bug resolved by #8 and a reproducible bug with GitLab's Junit parser which I reported to them.

I'm comfortable with calling this stable and moving it to nuget. Any reason not to do that?

codito commented 5 years ago

@Siphonophora sounds great to me. One last todo :) Would you mind adding your nuget.org alias as owner to https://github.com/spekt/junit.testlogger/blob/master/src/package/JUnitXml.TestLogger.nuspec? I will push the next successful appveyor build to nuget.

I think circleci may work if we install mono similar to the travisci build. This doesn't block the nuget release.

Thanks for testing and the hard work!

Siphonophora commented 5 years ago

@codito All set. By the way the Travis CI build is acting like its broken

codito commented 5 years ago

:fireworks: https://www.nuget.org/packages/JUnitXml.TestLogger

Master build for travis ci seems to succeed. Please share the failed build link, I will take a look. https://travis-ci.com/spekt/junit.testlogger

Siphonophora commented 5 years ago

This is what I meant. image

Siphonophora commented 5 years ago

By the way, do I need to do something else to show up on the owner's list on the Nuget page?

In terms of next steps, I was going to see if I can get this added to docs for vstest, GitLab and CircleCI. Is there anything else that makes sense to try for?

codito commented 5 years ago

It's weird that nuget is not showing you as an owner. We used the same publish to nuget via myget mechanism used for other packages in spekt org. Have added your alias manually in nuget.org.

Fixed the appveyor build badge and nuget badge in readme. Good catch, missed correcting this when the forked repo was removed :-/

Absolutely makes sense to add in the docs for the CI systems. Here's the vstest docs: https://github.com/microsoft/vstest-docs/blob/master/docs/report.md. No more tasks on top of my mind :)

Siphonophora commented 5 years ago

Figured out the nuget thing. I needed to agree to be listed as an owner, and had just missed the email from nuget about that.

codito commented 4 months ago

Fixed with https://github.com/spekt/testlogger/commit/5c5995c20fbd797e60408b529bc8203fdb8df20d