spekt / junit.testlogger

JUnit test logger for vstest platform (<= v3.x)
MIT License
76 stars 15 forks source link

Release v3.0.125 #67

Closed DerMolly closed 1 year ago

DerMolly commented 1 year ago

Apparently the same thing happened again as it did with https://github.com/spekt/junit.testlogger/issues/54

Maybe it would be benefical to include a release checklist in the repo to mitgate this problem in the future?

codito commented 1 year ago

@DerMolly is it possible for you quickly try this Pre release package if it fixes the issue? https://www.myget.org/feed/spekt/package/nuget/JunitXml.TestLogger/3.0.134

codito commented 1 year ago

I can cut a release based on feedback. /cc:@siphonophora

DerMolly commented 1 year ago

@codito The problem was about not having a release or tag on GitHub. I'm not sure what I should test? It seems to me (and I may be wrong) that both 3.0.125 and 3.0.134 are not present in this repo (neither as tags or as releases). grafik grafik

codito commented 1 year ago

@DerMolly the link I shared is for a pre-release package (3.0.134). We use a myget feed for unreleased packages, tags are created for the nuget packages.

We can test pre-release package like this:

> cd <path of the test project using junit logger> # or create a new test project with `dotnet new`
> dotnet add package JunitXml.TestLogger --version 3.0.134 --source https://www.myget.org/F/spekt/api/v3/index.json
# add the failing test
> dotnet test --logger:junit

3.0.125 is a release package and should have a tag and release notes. We will create it.

DerMolly commented 1 year ago

I don't have any problems with the package what so ever. I only noticed while renovate suggested my to update this package that there are no releases and therefore no release notes to gather if I need to change anything. I mean it's a patch release so I would not suspect as much, but I try to always have a quick look anyway. If this will be added I thank you very much.

codito commented 1 year ago

@DerMolly we have unlisted 3.0.125, it was missing the intended fix. Latest release is https://github.com/spekt/junit.testlogger/releases/tag/v3.0.134 and https://www.nuget.org/packages/JunitXml.TestLogger/3.0.134.

Closing this issue. Thanks again for the feedback!