Handle illegal xml char

spekt / nunit.testlogger

NUnit logger for vstest platform (<= v3.x)

MIT License

53 stars 26 forks source link

Handle illegal xml char #98

Closed Siphonophora closed 1 year ago

Siphonophora commented 1 year ago

Depends on https://github.com/spekt/testlogger/pull/37 to be merged then we can use the new package

Siphonophora commented 1 year ago

@codito In NUnitXmlSeralizer, I am not sure what to do with these two methods below. They both have code that is specific to NUnit framework and they are the only place we are using TestCase.Properties.

CreateSeedAttribute
CreatePropertiesElement - uses GetPropertyValue which looks like it might be tricky to replicate if we tried to follow the same approach of sanitizing all data before loading into TestResultInfo.

codito commented 1 year ago

CreateSeedAttribute doesn't have user inputs. It is okay to not sanitize it.

CreatePropertiesElement will need sanitization. Let's use InputSanitizer.Sanitize directly here?

codito commented 1 year ago

Open items:

(1) An alternative to exposing TestProperty directly is to fix https://github.com/spekt/testlogger/issues/17 via the adapter specific extensions in core testlogger. We need to resolve https://github.com/spekt/testlogger/issues/17 before merging this.

(2) TestCaseDisplayName and MethodFormat extensibility should be in core testlogger?

codito commented 1 year ago

Continued in https://github.com/spekt/nunit.testlogger/pull/100