Closed mregen closed 2 months ago
@mregen thank you for reporting this issue. OOM from a logger is indeed strange.
Is the log file becoming too big here? Should the xml logger be removed?
The logger is only used if --logger nunit
is specified in dotnet test
or vstest.console.exe
commandline. I couldn't find any references to the logger getting invoked in the test pipelines. So, may be nunit logger is no longer used in the tests and can be safely removed from this project.
I will try to do some stress tests with large # of tests and see if we can see any memory fluctuations across the two releases of this logger.
Hi @codito, in the meantime I tested to completely remove the nunitxml.testlogger, and in certain cases I reproducibly still hit the outofmemory exception. So I think it was coincidence when bumping the lib that the error occurs. The root cause is probably that some log file gets too big, then nunit loads some huge result file that blows the memory manager. Sorry for the confusion!
Describe the bug
After bumping to 4.0.254, https://github.com/OPCFoundation/UA-.NETStandard/pull/2691, the ci test for opc.Ua.Core.Tests is running out of memory before the testing finishes. Appears to be only with net48:
https://opcfoundation.visualstudio.com/opcua-netstandard/_test/analytics?definitionId=14&contextType=build
It is yet unclear how this can happen , because the failing test project has no dependency to this lib, another test project has. Tested that downgrading the lib in the other project fixes the issue.
Is the log file becoming too big here? Should the xml logger be removed?
dotnet test --logger:xyz...
Expected behavior
Tests run and pass without Outofmemoryexception
Other details
dotnet test --diag:log.txt
to the issue. Please redact any confidential info from the logs before attaching. See https://github.com/spekt/testlogger/wiki/Collecting-vstest-logsAdditional context Add any other context about the problem here.