search

spekulatius / PHPScraper

A universal web-util for PHP.
https://phpscraper.de
GNU General Public License v3.0
527 stars 74 forks source link

added phpstan in github actions #184

Closed nadar closed 1 year ago

nadar commented 1 year ago

i saw there is phpstan, but not configured for github actions. Maybe you like it otherwise close the PR.

If we increase to phpstan level 4 you'll get a https://phpstan.org/blog/bring-your-exceptions-under-control#dead-catch-reporting-in-bleeding-edge.

in order to test local use composer phpstan

spekulatius commented 1 year ago

Hey @nadar

phpstan is a great addition, I've added a note about the path.

Cheers, Peter

spekulatius commented 1 year ago

I've just noticed I can fix it too. Merged! Thank you @nadar!

nadar commented 1 year ago

:+1: if this is what you want, perfect. Do you relay on the unix path /tmp? I would not do so and use project specific paths and ignore them, otherwise windows users will have a problem. anyhow, its your choice i'm fine or might misunderstood you.

spekulatius commented 1 year ago

Hey @nadar,

good point about the Windows Users. I haven't used Windows in 20+ years and tent to ignore it. I'll prepare a patch reverting to your approach of a local path.

Cheers, Peter

nadar commented 1 year ago

Me neither :-) but market share is still big i would say, also that Microsoft more and more points into the developer sector (acquiring github, vscode, WSL, etc.)

image

But anyhow, also for CI/CD usage, never design a "system" which requires a "global scope".

spekulatius commented 1 year ago

The avoiding of global scope/context is a good idea. I'll keep it in mind :) It's merged :)