Fix typos and a critical error

spekulatius / PHPScraper

A universal web-util for PHP.

https://phpscraper.de

GNU General Public License v3.0

509 stars 73 forks source link

Closed szepeviktor closed 10 months ago

szepeviktor commented 10 months ago

Found misspellings. While fixing them found a critical error.

szepeviktor commented 10 months ago

Oh no! This is more tricky then I thought.

Making a second commit ... 🏃🏻‍♂️

szepeviktor commented 10 months ago

❌ NavigationTest::testSurfWithAbsoluteLink fails as link on https://test-pages.phpscraper.de/navigation/1.html changed.

spekulatius commented 10 months ago

Hello @szepeviktor,

Thank you for your PR!

I've found the issue behind the tests failing: A setting for pretty URLs was active on Netlify. I've adjusted it and re-run the tests! Looks good!

I've squashed and merged it :muscle:

Cheers, Peter

szepeviktor commented 10 months ago

Glad to contribute.