search

spekulatius / PHPScraper

A universal web-util for PHP.
https://phpscraper.de
GNU General Public License v3.0
509 stars 73 forks source link

Fix few problems reported by PHPStan #192

Closed szepeviktor closed 10 months ago

szepeviktor commented 10 months ago

@spekulatius If you like robust code you may continue fixing the rest of the problems.

(otherwise just close it - this is an inspiration)

szepeviktor commented 10 months ago

❌ NavigationTest::testSurfWithAbsoluteLink fails as link on https://test-pages.phpscraper.de/navigation/1.html changed.

spekulatius commented 10 months ago

Hey @szepeviktor,

Thank you for taking the time to prepare a PR! I can see there are areas that need improving.

I've replied to your comments and changes. Could you have a look and check the PHPStan issues?

Do you think anything else should go into this?

Cheers, Peter

szepeviktor commented 10 months ago

Do you think anything else should go into this?

Yes. Your work :)

szepeviktor commented 10 months ago

The next step is to remove ignoreErrors from PHPStan configuration. It is up to you!