search

spekulatius / PHPScraper

A universal web-util for PHP.
https://phpscraper.de
GNU General Public License v3.0
527 stars 74 forks source link

Upgrading Symfony dependencies to allow ^7.0 #204

Closed tentacode closed 5 months ago

tentacode commented 6 months ago

Hello there and thanks for the scrapper, cant't wait to try it ! 👋

I could not install PHPScraper on a Symfony 7 project, I figured I'd just fork it.

I don't really know what you do expect as a contribution so don't hesitate to ask for more / redo it yourself or even close it, meanwhile I'm just using my fork and it works.

composer install and tests are passing on PHP 8.3 on my side

spekulatius commented 6 months ago

Hello @tentacode,

Thank you for your PR! Can you check the failing "Checks" and see if you can fix them?

Cheers, Peter

tentacode commented 6 months ago

I upgraded rector to ^0.19, there seem to be a dependency issue with phpstan that has been fixed meanwhile. Also I ran pint to fix coding standard, even though I don't know why the code was not ok. 🤷‍♂️

tentacode commented 5 months ago

ping @spekulatius :) if you can restart the workflow so that I can see if it's all ok 👌🙏

spekulatius commented 5 months ago

Thanks for the ping @tentacode , it's running :)

spekulatius commented 5 months ago

Looks good @tentacode! Thank you! I'll prepare a new release shortly.

spekulatius commented 5 months ago

Done, thank you @tentacode!