laravel 9 support - Githubissues

spekulatius / spatie-crawler-toolkit-for-laravel

A toolkit for Spatie's Crawler and Laravel.

https://releasecandidate.dev

MIT License

18 stars 8 forks source link

laravel 9 support #9

Closed henzeb closed 1 year ago

henzeb commented 2 years ago

Atm there is no laravel 9 support.

Problem 1

Root composer.json requires spekulatius/spatie-crawler-toolkit-for-laravel ^0.4.0 -> satisfiable by spekulatius/spatie-crawler-toolkit-for-laravel[0.4.0].
spekulatius/spatie-crawler-toolkit-for-laravel 0.4.0 requires laravel/framework ^6.0|^7.0|^8.0 -> found laravel/framework[v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but it conflicts with your root composer.json require (^9.2).

spekulatius commented 2 years ago

Hello @henzeb,

Are you interested in supporting the package with Laravel 9 support? You could fork it, adjust composer.json and check if / where the issues with Laravel 9 are.

Cheers, Peter

henzeb commented 2 years ago

Just did, I tested the queue, haven't tested the events yet, but It looks like it works like a charm.

The only thing is that ?$ttl requires you to add null to the constructor. Your readme may make it look like you don't need to.

https://github.com/henzeb/spatie-crawler-toolkit-for-laravel/tree/laravel-9

spekulatius commented 1 year ago

Fixed, please let me know if any issues come up :+1: