speleolontra / daikin_residential_altherma

Home Assistant Integration specific for BRP069A78 Heat Pump Model, via Daikin App Onecta. Users have good experience also for BRP069A62 and BRP069A61 (but not tested directly).
GNU General Public License v3.0
98 stars 14 forks source link

Provide control for hot water tank #14

Closed jwillemsen closed 1 year ago

jwillemsen commented 2 years ago

I am a HA beginner, so storing some ideas here. Currently this integration provides one climate entity for the Altherma, but the Altherma does include a separate hot water boiler, maybe that can be exposed separately as a water heater entity (see https://developers.home-assistant.io/docs/core/entity/water-heater), so that it can receive its independent settings for target_temperature.

The tank properties of the DaikinClimate can move to there.

jwillemsen commented 2 years ago

I think this could be a nice next step, let us first get the energy fields and target temperature with cleanup into master, after that look at this support.

jwillemsen commented 2 years ago

The boost option should move to the water heater at that moment

jwillemsen commented 2 years ago

ACS_state looks to be the on/off state of the tank

jwillemsen commented 2 years ago

20 and #22 are also for the hot water tank

jwillemsen commented 2 years ago

There is another project doing something similar for the Altherma 3, see https://github.com/stoyandim/daikin_residential_brp069a62_opentherm/blob/main/custom_components/daikin_residential_brp069a62_opentherm/water_heater.py for their hot water tank support

jwillemsen commented 2 years ago

Maybe at the moment the hot water entity is a separate entity we can make the altherma itself a different entity and rework the code a little bit so that it can be part of the daikin_residential project, just one integration for daikin residential support

colseven commented 2 years ago

this is a really great project! Since I have a solar system, I would of course like to store the excess energy in the hot water tank, so it would be very important if you could set the hot water setpoint temperature.

would be really great if this would be integrated.

harnie1979 commented 2 years ago

Thank you, works perfect with the BRP069A78 WLAN Gateway. I created a automation in HA that checks the condition of the tank, if below 38 degrees Celsius and if my solar panels are generating more then 500 w/per hour then boost my tank water until 45 degrees is reached. After this boost will be disabled and the heatpump is doing it in normal mode. Thnxx again.

jwillemsen commented 2 years ago

See https://github.com/tadasdanielius/daikin_altherma/blob/main/custom_components/daikin_altherma/water_heater.py as another daikin integration which does this

CodingTfC commented 2 years ago

Thank you for this nice integration. I would love to see further invention for controlling the target temperatures for tank and leaving water :) Great work so far 👍🏽

palecs commented 1 year ago

@jwillemsen is there any chance you can add water tank temperature control, so we can set the temperature in automation? like it is here https://github.com/tadasdanielius/daikin_altherma/blob/main/custom_components/daikin_altherma/water_heater.py ? Everything is perfect, thank you working with few fixes like a charm. Thank you.

jwillemsen commented 1 year ago

As this is all unsponsored work it is low on my priority list, no idea when I will get time to implement this issue

colseven commented 1 year ago

@jwillemsen

Okay then we have to support you in your work. Since we can't actually contribute anything, only dollars remain. What do you need to integrate this function?

jwillemsen commented 1 year ago

I will try a few things @colseven, sponsoring through github is always welcome

palecs commented 1 year ago

Hello share method of sponsorship and I will participate also. Thank you.

pi 17. 2. 2023 o 9:25 Johnny Willemsen @.***> napísal(a):

I will try a few things @colseven https://github.com/colseven, sponsoring through github is always welcome

— Reply to this email directly, view it on GitHub https://github.com/speleolontra/daikin_residential_altherma/issues/14#issuecomment-1434287908, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACAUKLYSIHF4COZV3KLEX3DWX4YVZANCNFSM5M27HCPA . You are receiving this because you commented.Message ID: @.***>

-- S pozdravom Ing. Pavol Závacký, PhD.

jwillemsen commented 1 year ago

See #85

palecs commented 1 year ago

hello @jwillemsen I was checking your code and it is really really good start and can provide almost all requested functionality :D. What time it usually takes, that new requests are merged in main thread? Thank you.

palecs commented 1 year ago

Hello @jwillemsen after importing your code im getting this error:

Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 442, in async_add_entities await asyncio.gather(*tasks) File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 629, in _async_add_entity capabilities=entity.capability_attributes, File "/usr/src/homeassistant/homeassistant/components/water_heater/__init__.py", line 195, in capability_attributes self.hass, self.min_temp, self.temperature_unit, self.precision File "/config/custom_components/daikin_residential_altherma/water_heater.py", line 131, in min_temp stepVal = self._device.dhw_target_temperature_minValue AttributeError: 'Appliance' object has no attribute 'dhw_target_temperature_minValue'

Thank you for great work.

jwillemsen commented 1 year ago

@palecs Have you checked our the correct branch, should be https://github.com/jwillemsen/daikin_residential_altherma/tree/jwi-gateway. In my branch that attribute is not there

jwillemsen commented 1 year ago

Can you attach the script here, will try to have another look next week

jwillemsen commented 1 year ago

Implemented this support