search

speleolontra / daikin_residential_altherma

Home Assistant Integration specific for BRP069A78 Heat Pump Model, via Daikin App Onecta. Users have good experience also for BRP069A62 and BRP069A61 (but not tested directly).
GNU General Public License v3.0
98 stars 14 forks source link

Fallback code for BigFoot2020 #9

Closed jwillemsen closed 1 year ago

jwillemsen commented 2 years ago

In several files there is code which does something special when None is returned, there is a comment "BigFoot2020" related to those lines, do those need to be kept, at least with my daikin units I do get values with these calls

speleolontra commented 2 years ago

Thanks jwillemsen, you are great! Unfortunately, I'm not very familiar with git hub and will be a little slow on the uptake of your suggestions, but I promise to find some time to spend on it.

do you recommend that I compare my files with your branches? Thanks a lot

jwillemsen commented 2 years ago

I will try to make some PRs, did you add the BigFoot2020 code? I will check your daikin_data.json with mine when making changes.

speleolontra commented 2 years ago

Hi @jwillemsen , now, we have 5 rows with BigFoot2020 comment. immagine It's right? I can close the issue? Thanx

jwillemsen commented 2 years ago

Do we need that fallback code, any daikin_data.json I have seen before does have these fields and doesn't need the fallback code

jwillemsen commented 1 year ago

We don't need this anymore, see https://github.com/speleolontra/daikin_residential_altherma/pull/85/commits/a6ade4bd24c88a58ca8f7022682d51feade538f4 for the cleanup

jwillemsen commented 1 year ago

Code has been removed