search

spenap / butaca

Movie database application for the Nokia N9
GNU General Public License v3.0
7 stars 9 forks source link

Implement roleNames, remove call to setRoleNames #28

Closed lukedirtwalker closed 10 years ago

lukedirtwalker commented 10 years ago

as setRoleNames is deprecated in Qt5.

This commit does not change functionality but helps to keep the same codebase for Qt4 and Qt5

mporsch commented 10 years ago

Looks fine. Once I get home, I will create a development branch, merge your commit and push it back online. Please issue future pull requests against that branch.

Btw; do you test your code on a harmattan device or in the simulator?

lukedirtwalker commented 10 years ago

Okay great, will do. No I don't have the old SDK installed, so it would be cool if you could quickly test the things on the harmattan side as soon as every commit, which touches non-gui code, is in place. The one here and some others which relate to Qt5 compatibility should just work, but there might be 1 or 2 commits which need special attention but then I will let you know. Hope that works for you.

mporsch commented 10 years ago

Unfortunately, this patch causes a bug in TheatersView which leaves the cinema and subsequent movie list empty. No Idea why yet...

before after

mporsch commented 10 years ago

Btw: I created a branch "sailfish_integration" for further pull requests.

lukedirtwalker commented 10 years ago

Too bad, I'll probably have to install the old SDK then to figure this out