Sailfish integration - Githubissues

spenap / butaca

Movie database application for the Nokia N9

GNU General Public License v3.0

7 stars 9 forks source link

Sailfish integration #32

Closed lukedirtwalker closed 9 years ago

lukedirtwalker commented 9 years ago

Make Sailfish app usable: Still some rough edges Theaters doesn't work in Sailfish it would need a non Widget solution (as QWebView causes high CPU usage) for this I look into creating a JSON API around google movies but results are not yet satisfying.

@mporsch please have a look, and also check if it works like this in harmattan sdk

mporsch commented 9 years ago

Nice to see you're still on this! Mostly fine so far. 2 things:

my (outdated) build environment is not able to build for the simulator target out-of-the-box anymore, i.e. it does not get the BUILD_FOR_HARMATTAN define and dies when not finding the sailfish stuff. The device target works fine, though.
I see a segfault on close on the device. I am quite sure this has not been there before

mporsch commented 9 years ago

Oops. Never mind the segfault. That has been there before =D

lukedirtwalker commented 9 years ago

Cool thanks for merging. Hm Simulator and BUILD_FOR_HARMATTAN is not the same you can change by moving line 60 in src.pro to the outer scope I guess, but you'll have to check what where BUILD_FOR_HARMATTAN is used if you really want to do this ;)

There will come some more commits coming along mostly qml fixes in sailfish.

Also I took the freedom to release it on openrepos and will soon put it in Jolla store if you have any objections please tell me so.

Furthermore we should look how we handle translations I'm not familiar but maybe it's possible to use the same files?

mporsch commented 9 years ago

If it is possible to fix the harmattan simulator target without too much of a hassle, please do so.

I am absolutely fine with you publishing it on openrepos. Don't forget to add your name to the contributor list and acknowlegements inside the app! You deserve it more than I do ;) Concerning the store I assume you will publish it free of charge? I wouldn't mind, but the APIs used permit commercial use.

I think the translation files cannot be exactly reused as they seemed quite fixed on text positions? But things should be easy going if you keep the texts unchanged: Transifex translates all 100% matches automatically. There is a little guidance in the Translating.md file. I'll add you to the transifex organization once you are ready: just create an account and email me the name.

lukedirtwalker commented 9 years ago

No it will be free of course.

Hm I think I have some more words but I first have to look around and then we can discuss again if something is unclear.