search

spencer-project / spencer_people_tracking

Multi-modal ROS-based people detection and tracking framework for mobile robots developed within the context of the EU FP7 project SPENCER.
http://www.spencer.eu/
660 stars 327 forks source link

Fixed - Upper_body_detection segfault #14

Closed rentt closed 8 years ago

rentt commented 8 years ago

Open a new pull request with last update of spencer_people_tracking:master This patch is well tested and has been run stable for 4 hours with a kinect on a moving robot.

lucasb-eyer commented 8 years ago

Sorry to say this, but this is too big to be reviewable. In a pull-request, you should do one change at a time. I agree that indentation and spaces are all over the place and should be fixed, but mixed with all other things it makes the diff unreadable.

Also, as I say in #12, the returning of Vector by value does not cause a double-free.

Some of the fixes in there do look promising, for example 4bfb412, but mixed with so many other (mostly unnecessary) changes, it's not likely to be merged anytime soon. And I'm saying this while I really appreciate you giving back your fixes, it's just that none of us have the time to go through such a huge diff, and the original author is long gone.

rentt commented 8 years ago

Got it. It is terrible for reviewing such a huge diff :-( I will close the PR, and leave this patch in my fork. It should be a hint for this issue. Anyway it is running well on my robot:-) thanks for the work :+1:

lucasb-eyer commented 8 years ago

You're welcome, and thanks for trying to contribute back :) I may come back to this issue at some future time, the off-by-one fix seems good and maybe there's more. Good luck with your robot!