search

spencer516 / ember-d3-scale

Ember D3 Scale Helpers
MIT License
2 stars 1 forks source link

support copying the scale #7

Closed spencer516 closed 8 years ago

taras commented 8 years ago

What does this copy do?

spencer516 commented 8 years ago

The copy creates a duplicate of the scale. Part of the reason you were seeing that weird behavior is because d3-axis copies the scale before using it — and, because the guid-domain-scale here didn't implement it's own copy, copy would return a standard d3 scale, not an instance of the guid-domain-scale.

ghost commented 8 years ago

@spencer516 thanks, we tried this, it fixes our problem!

taras commented 8 years ago

Can you please pull this in :)

spencer516 commented 8 years ago

Yes!