spencerahill
commented
5 years ago On my local conda environmetn for python 3.7, our test suite all passes, with the warnings pasted below from upstream libraries. So, as hoped, this shouldn't cause much pain.
==================================================================== test session starts ====================================================================
platform darwin -- Python 3.7.0, pytest-3.10.0, py-1.7.0, pluggy-0.8.0
rootdir: /Users/shill/Dropbox/py/aospy, inifile: setup.cfg
collected 598 items
test_automate.py .................................... [ 6%]
test_calc_basic.py .................................................................................................................................. [ 27%]
........................................ [ 34%]
test_data_loader.py ................................................................................................................................. [ 56%]
................................. [ 61%]
test_region.py ............... [ 64%]
test_run.py ... [ 64%]
test_tutorial.py . [ 64%]
test_utils_io.py . [ 64%]
test_utils_longitude.py .............................................................................. [ 77%]
test_utils_times.py ................................................................................................................................. [ 99%]
[ 99%]
test_utils_vertcoord.py ... [100%]
===================================================================== warnings summary ======================================================================
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/utils.py:11
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/utils.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Iterable, Mapping, MutableMapping, MutableSet
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/utils.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Iterable, Mapping, MutableMapping, MutableSet
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/utils.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Iterable, Mapping, MutableMapping, MutableSet
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/utils.py:11: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Iterable, Mapping, MutableMapping, MutableSet
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/matplotlib/colors.py:53
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/matplotlib/colors.py:53: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Sized
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/yaml/constructor.py:126
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/yaml/constructor.py:126: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if not isinstance(key, collections.Hashable):
aospy/test/test_automate.py::test_submit_mult_calcs_external_client[exec_options0]
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/bokeh/embed/util.py:25: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Sequence, OrderedDict
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/tornado/concurrent.py:521: DeprecationWarning: @return_future is deprecated, use coroutines instead
DeprecationWarning)
aospy/test/test_calc_basic.py::test_compute_pressure
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/options.py:49: FutureWarning: The enable_cftimeindex option is now a no-op and will be removed in a future version of xarray.
FutureWarning)
aospy/test/test_calc_basic.py::test_compute_pressure_thicknesses
/Users/shill/Dropbox/miniconda3/envs/py37/lib/python3.7/site-packages/xarray/core/options.py:49: FutureWarning: The enable_cftimeindex option is now a no-op and will be removed in a future version of xarray.
FutureWarning)
-- Docs: https://docs.pytest.org/en/latest/warnings.html
========================================================= 598 passed, 10 warnings in 137.93 seconds =========================================================
Should be straightforward, c.f. https://github.com/pydata/xarray/pull/2271
Although we might as well wait until they've merged that one, including figuring out the Travis issues referenced in that PR.