search

spencerahill / aospy

Python package for automated analysis and management of gridded climate data
Apache License 2.0
83 stars 12 forks source link

Compatibility for NOAA and IRIDL data sets #309

Closed jdossgollin closed 5 years ago

jdossgollin commented 5 years ago

Closes #293 and #299. This PR makes two changes which make aospy compatible with a greater range of data sets, specifically including those from the IRI Data Library and NOAA data sets such as the NCEP-NCAR Reanalysis. This compatibility is expanded through (1) the addition of several new names for GRID_ATTRS as discussed in #293 (for X, Y, P, and #299 (for nbnds); land was not discussed in a previous issue but is also a relevant use case without likelihood of confusion, and (2) a modification of ensure_time_avg_has_cf_metadata to avoid the assumption that BOUNDS_STR is a coordinate of time_weights as discussed in #299.

spencerahill commented 5 years ago

Thanks much @jdossgollin ! Congrats on your first aospy PR, and sorry again for those aspects of the procedure that we accidentally made pretty confusing.

jdossgollin commented 5 years ago

Thanks for the patience and guidance @spencerahill and @spencerkclark !

spencerahill commented 5 years ago

No problem at all. Looking forward to additional future contributions from you :)